Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): vscode rename accidentally renames keyword arguments #7017

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

tsuf239
Copy link
Collaborator

@tsuf239 tsuf239 commented Aug 13, 2024

fixed #7016
and added tests :)

@eladb FYI

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@tsuf239 tsuf239 requested a review from a team as a code owner August 13, 2024 15:14
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@tsuf239 tsuf239 changed the title fix(vscode): VSCode rename accidentally renames keyword arguments fix(vscode): vscode rename accidentally renames keyword arguments Aug 13, 2024
@monadabot
Copy link
Contributor

monadabot commented Aug 13, 2024

Console preview environment is available at https://wing-console-pr-7017.fly.dev 🚀

Last Updated (UTC) 2024-09-11 09:57

@monadabot
Copy link
Contributor

monadabot commented Aug 13, 2024

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 55ms±0.53 55ms±0.42 0ms (-0.67%)⬜
functions_10.test.w -t sim 489ms±13.57 515ms±30.87 +26ms (+5.33%)🟥
functions_10.test.w -t tf-aws 2237ms±137.12 2141ms±22.68 -96ms (-4.28%)⬜
jsii_small.test.w -t sim 377ms±3.97 371ms±3.1 -6ms (-1.63%)⬜
jsii_small.test.w -t tf-aws 600ms±6.02 599ms±6.17 -1ms (-0.2%)⬜
functions_1.test.w -t sim 401ms±4.44 398ms±3.37 -2ms (-0.56%)⬜
functions_1.test.w -t tf-aws 834ms±6.76 818ms±4.3 -16ms (-1.92%)⬜
empty.test.w -t sim 366ms±3.24 359ms±3.59 -7ms (-1.82%)⬜
empty.test.w -t tf-aws 593ms±5.42 585ms±3.9 -8ms (-1.42%)⬜
hello_world.test.w -t sim 409ms±6.51 397ms±4.85 -11ms (-2.72%)⬜
hello_world.test.w -t tf-aws 1469ms±4.19 1457ms±8.44 -12ms (-0.79%)⬜
jsii_big.test.w -t sim 2920ms±21.34 2913ms±10.25 -7ms (-0.24%)⬜
jsii_big.test.w -t tf-aws 3138ms±10.33 3124ms±15.69 -14ms (-0.43%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 55ms 54ms 56ms 0ms 1ms
functions_10.test.w -t sim 515ms 478ms 612ms 31ms 43ms
functions_10.test.w -t tf-aws 2141ms 2090ms 2190ms 23ms 32ms
jsii_small.test.w -t sim 371ms 365ms 376ms 3ms 4ms
jsii_small.test.w -t tf-aws 599ms 585ms 612ms 6ms 9ms
functions_1.test.w -t sim 398ms 393ms 409ms 3ms 5ms
functions_1.test.w -t tf-aws 818ms 806ms 826ms 4ms 6ms
empty.test.w -t sim 359ms 349ms 366ms 4ms 5ms
empty.test.w -t tf-aws 585ms 577ms 596ms 4ms 5ms
hello_world.test.w -t sim 397ms 390ms 410ms 5ms 7ms
hello_world.test.w -t tf-aws 1457ms 1436ms 1472ms 8ms 12ms
jsii_big.test.w -t sim 2913ms 2890ms 2933ms 10ms 14ms
jsii_big.test.w -t tf-aws 3124ms 3067ms 3149ms 16ms 22ms
Last Updated (UTC) 2024-09-09 12:49

Copy link

github-actions bot commented Sep 3, 2024

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community Discord.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

@github-actions github-actions bot added the Stale label Sep 3, 2024
@tsuf239 tsuf239 removed the Stale label Sep 9, 2024
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/@winglang/wingc/src/lsp/rename_visitor.rs Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/fixing-rename-named-args is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 11, 2024
@mergify mergify bot merged commit fb736d5 into main Sep 11, 2024
15 checks passed
@mergify mergify bot deleted the tsuf/fixing-rename-named-args branch September 11, 2024 10:05
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode rename accidentally renames keyword arguments
3 participants