Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows snapshot sanitation #6987

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Aug 5, 2024

Resolve an issue currently causing snapshot mismatches on Windows (https://github.com/winglang/wing/actions/runs/10256182184/job/28374831039) that was missed in #6980

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner August 5, 2024 21:37
Copy link

github-actions bot commented Aug 5, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.49 58ms±0.64 +0ms (+0.07%)⬜
empty.test.w -t sim 379ms±4.85 392ms±16.7 +13ms (+3.3%)🟥
empty.test.w -t tf-aws 629ms±4.07 612ms±6.2 -17ms (-2.73%)⬜
hello_world.test.w -t sim 420ms±4.31 410ms±12.07 -10ms (-2.44%)⬜
hello_world.test.w -t tf-aws 1516ms±9.53 1494ms±13.79 -22ms (-1.44%)⬜
jsii_small.test.w -t sim 387ms±5.79 381ms±4.42 -6ms (-1.64%)⬜
jsii_small.test.w -t tf-aws 631ms±4.48 630ms±4.5 -1ms (-0.23%)⬜
jsii_big.test.w -t sim 2977ms±19.87 2981ms±14.7 +5ms (+0.15%)⬜
jsii_big.test.w -t tf-aws 3206ms±11.79 3161ms±16.63 -45ms (-1.41%)⬜
functions_1.test.w -t sim 419ms±6.28 403ms±5.23 -15ms (-3.6%)⬜
functions_1.test.w -t tf-aws 887ms±4.69 852ms±7.84 -35ms (-3.98%)⬜
functions_10.test.w -t sim 520ms±11.39 475ms±16.98 -45ms (-8.73%)⬜
functions_10.test.w -t tf-aws 2273ms±11.34 2171ms±17.79 -102ms (-4.47%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 57ms 59ms 1ms 1ms
empty.test.w -t sim 392ms 373ms 452ms 17ms 23ms
empty.test.w -t tf-aws 612ms 599ms 625ms 6ms 9ms
hello_world.test.w -t sim 410ms 396ms 456ms 12ms 17ms
hello_world.test.w -t tf-aws 1494ms 1481ms 1545ms 14ms 19ms
jsii_small.test.w -t sim 381ms 370ms 388ms 4ms 6ms
jsii_small.test.w -t tf-aws 630ms 621ms 638ms 5ms 6ms
jsii_big.test.w -t sim 2981ms 2950ms 3006ms 15ms 21ms
jsii_big.test.w -t tf-aws 3161ms 3135ms 3216ms 17ms 23ms
functions_1.test.w -t sim 403ms 393ms 414ms 5ms 7ms
functions_1.test.w -t tf-aws 852ms 839ms 869ms 8ms 11ms
functions_10.test.w -t sim 475ms 432ms 500ms 17ms 24ms
functions_10.test.w -t tf-aws 2171ms 2133ms 2210ms 18ms 25ms
Last Updated (UTC) 2024-08-05 21:47

@Chriscbr Chriscbr merged commit 136c844 into main Aug 5, 2024
24 checks passed
@Chriscbr Chriscbr deleted the rybickic/fix-windows-snaps branch August 5, 2024 21:56
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.81.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants