fix(sdk): simulator lockfile race condition during release #6935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the lockfile would try to update the lockfile utimes after it was released due to the async nature of the implementation. This changeset refactors the implementation so it's purely sync. In the future, the implementation could be refactored into async again, but the release method should wait for the lockfile update before actually releasing the lockfile (if it's actually happening during the release call).
|
Thanks for opening this pull request! 🎉
|
skyrpex
changed the title
|
Console preview environment is available at https://wing-console-pr-6935.fly.dev 🚀 Last Updated (UTC) 2024-07-23 10:26 |
polamoros
approved these changes
Jul 23, 2024
|
Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if |
|
Congrats! 🚀 This was released in Wing 0.79.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the lockfile would try to update the lockfile utimes while it was being released due to the async nature of the implementation. This changeset refactors the implementation so it's purely sync.