Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support api requests in bring UI #6239

Merged
merged 23 commits into from
Apr 15, 2024

Conversation

polamoros
Copy link
Contributor

Resolves #6131

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Apr 15, 2024

Console preview environment is available at https://wing-console-pr-6239.fly.dev 🚀

Last Updated (UTC) 2024-04-15 18:39

@monadabot
Copy link
Contributor

monadabot commented Apr 15, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥🟥⬜
Benchmark Before After Change
version 59ms±0.61 59ms±0.86 +0ms (+0.34%)⬜
functions_1.test.w -t sim 403ms±22.04 390ms±3.34 -12ms (-3.1%)⬜
functions_1.test.w -t tf-aws 809ms±7.46 821ms±8.83 +12ms (+1.44%)⬜
hello_world.test.w -t sim 389ms±3.99 399ms±10.06 +11ms (+2.73%)⬜
hello_world.test.w -t tf-aws 1505ms±9.23 1519ms±16.17 +13ms (+0.89%)⬜
jsii_big.test.w -t sim 2778ms±12.49 2773ms±11.99 -5ms (-0.17%)⬜
jsii_big.test.w -t tf-aws 2987ms±12.54 2997ms±18.56 +11ms (+0.36%)⬜
functions_10.test.w -t sim 483ms±9.61 494ms±8.76 +11ms (+2.22%)⬜
functions_10.test.w -t tf-aws 1997ms±9.47 1997ms±10.58 +0ms (+0.01%)⬜
jsii_small.test.w -t sim 363ms±4.69 365ms±3.55 +2ms (+0.5%)⬜
jsii_small.test.w -t tf-aws 593ms±4.14 606ms±3.25 +12ms (+2.05%)🟥
empty.test.w -t sim 356ms±2.85 362ms±2.8 +6ms (+1.69%)🟥
empty.test.w -t tf-aws 588ms±5.47 600ms±7.44 +12ms (+1.99%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 62ms 1ms 1ms
functions_1.test.w -t sim 390ms 384ms 400ms 3ms 5ms
functions_1.test.w -t tf-aws 821ms 804ms 840ms 9ms 12ms
hello_world.test.w -t sim 399ms 383ms 434ms 10ms 14ms
hello_world.test.w -t tf-aws 1519ms 1496ms 1570ms 16ms 23ms
jsii_big.test.w -t sim 2773ms 2747ms 2797ms 12ms 17ms
jsii_big.test.w -t tf-aws 2997ms 2966ms 3036ms 19ms 26ms
functions_10.test.w -t sim 494ms 473ms 509ms 9ms 12ms
functions_10.test.w -t tf-aws 1997ms 1972ms 2023ms 11ms 15ms
jsii_small.test.w -t sim 365ms 354ms 371ms 4ms 5ms
jsii_small.test.w -t tf-aws 606ms 597ms 611ms 3ms 5ms
empty.test.w -t sim 362ms 356ms 368ms 3ms 4ms
empty.test.w -t tf-aws 600ms 588ms 625ms 7ms 10ms
Last Updated (UTC) 2024-04-15 18:44

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 15, 2024
@polamoros polamoros marked this pull request as ready for review April 15, 2024 14:04
@polamoros polamoros requested review from ainvoner, skyrpex, eladcon and a team as code owners April 15, 2024 14:04
Copy link
Contributor

@skyrpex skyrpex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ainvoner ainvoner added ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! and removed ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! labels Apr 15, 2024
@monadabot
Copy link
Contributor

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (a86c6ce) for suspicious changes.
This is typically caused by:

  • Absolute paths
  • Timestamps
  • Random values
  • Flakey tests (relying on one of the above)

@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 15, 2024
Copy link
Contributor

mergify bot commented Apr 15, 2024

Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if 6131-support-api-requests-in-bring-ui is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit ecc4ffc into main Apr 15, 2024
15 checks passed
@mergify mergify bot deleted the 6131-support-api-requests-in-bring-ui branch April 15, 2024 18:45
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.70.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support API requests in bring ui
5 participants