Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): aws.BucketRef #6210

Merged
merged 10 commits into from
Apr 16, 2024
Merged

feat(sdk): aws.BucketRef #6210

merged 10 commits into from
Apr 16, 2024

Conversation

eladcon
Copy link
Collaborator

@eladcon eladcon commented Apr 11, 2024

Reference an existing s3 bucket with aws.BucketRef

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@eladcon eladcon requested a review from a team as a code owner April 11, 2024 09:56
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Apr 11, 2024

Console preview environment is available at https://wing-console-pr-6210.fly.dev 🚀

Last Updated (UTC) 2024-04-16 09:48

@monadabot
Copy link
Contributor

monadabot commented Apr 11, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜
Benchmark Before After Change
version 58ms±0.56 59ms±0.55 +1ms (+1.75%)⬜
functions_1.test.w -t sim 391ms±2.91 394ms±4.77 +3ms (+0.89%)⬜
functions_1.test.w -t tf-aws 807ms±4.27 826ms±18.15 +19ms (+2.29%)⬜
hello_world.test.w -t sim 388ms±3.58 398ms±9.1 +10ms (+2.63%)⬜
hello_world.test.w -t tf-aws 1498ms±20.05 1513ms±16.6 +14ms (+0.95%)⬜
jsii_big.test.w -t sim 2769ms±11.43 2772ms±14.29 +3ms (+0.11%)⬜
jsii_big.test.w -t tf-aws 2976ms±16.18 2984ms±13.45 +8ms (+0.26%)⬜
functions_10.test.w -t sim 478ms±7.1 486ms±5.18 +9ms (+1.83%)⬜
functions_10.test.w -t tf-aws 2004ms±12.75 1994ms±12 -10ms (-0.48%)⬜
jsii_small.test.w -t sim 361ms±2.94 367ms±3.93 +6ms (+1.62%)⬜
jsii_small.test.w -t tf-aws 595ms±4.33 604ms±3.12 +9ms (+1.58%)🟥
empty.test.w -t sim 358ms±2.85 361ms±3.39 +3ms (+0.96%)⬜
empty.test.w -t tf-aws 587ms±4.13 592ms±3.84 +5ms (+0.88%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 60ms 1ms 1ms
functions_1.test.w -t sim 394ms 385ms 405ms 5ms 7ms
functions_1.test.w -t tf-aws 826ms 803ms 885ms 18ms 25ms
hello_world.test.w -t sim 398ms 383ms 430ms 9ms 13ms
hello_world.test.w -t tf-aws 1513ms 1491ms 1561ms 17ms 23ms
jsii_big.test.w -t sim 2772ms 2747ms 2807ms 14ms 20ms
jsii_big.test.w -t tf-aws 2984ms 2960ms 3023ms 13ms 19ms
functions_10.test.w -t sim 486ms 477ms 499ms 5ms 7ms
functions_10.test.w -t tf-aws 1994ms 1969ms 2023ms 12ms 17ms
jsii_small.test.w -t sim 367ms 359ms 377ms 4ms 6ms
jsii_small.test.w -t tf-aws 604ms 596ms 609ms 3ms 4ms
empty.test.w -t sim 361ms 356ms 370ms 3ms 5ms
empty.test.w -t tf-aws 592ms 587ms 600ms 4ms 5ms
Last Updated (UTC) 2024-04-16 09:52

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 11, 2024
libs/wingsdk/src/shared-aws/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/ui/field.ts Outdated Show resolved Hide resolved
@eladcon eladcon removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 16, 2024
Copy link
Contributor

mergify bot commented Apr 16, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if bucket-ref is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 9348f9a into main Apr 16, 2024
15 checks passed
@mergify mergify bot deleted the bucket-ref branch April 16, 2024 11:36
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.70.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants