Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): can retrieve empty object from bucket on AWS platforms #6091

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

garysassano
Copy link
Collaborator

@garysassano garysassano commented Mar 29, 2024

Closes #5740

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner March 29, 2024 04:21
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@garysassano garysassano changed the title fix get empty object from bucket for AWS platforms fix(sdk): can retrieve empty object from bucket on AWS platforms Mar 29, 2024
@monadabot
Copy link
Contributor

monadabot commented Mar 29, 2024

Console preview environment is available at https://wing-console-pr-6091.fly.dev 🚀

Last Updated (UTC) 2024-03-29 05:03

@monadabot
Copy link
Contributor

monadabot commented Mar 29, 2024

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜🟥🟥🟥🟥⬜🟥🟥⬜⬜
Benchmark Before After Change
version 57ms±0.54 59ms±0.56 +2ms (+3.91%)🟥
empty.test.w -t sim 348ms±5.99 352ms±4.97 +4ms (+1.19%)⬜
empty.test.w -t tf-aws 580ms±5.2 589ms±5.08 +8ms (+1.46%)⬜
hello_world.test.w -t sim 381ms±3.19 387ms±4.62 +7ms (+1.79%)⬜
hello_world.test.w -t tf-aws 1511ms±13.72 1543ms±14.49 +32ms (+2.1%)🟥
functions_10.test.w -t sim 459ms±4.55 481ms±4.84 +22ms (+4.83%)🟥
functions_10.test.w -t tf-aws 2089ms±8.85 2163ms±12.38 +74ms (+3.55%)🟥
jsii_small.test.w -t sim 357ms±5.19 372ms±4.75 +15ms (+4.26%)🟥
jsii_small.test.w -t tf-aws 596ms±4.55 613ms±7.9 +16ms (+2.72%)⬜
jsii_big.test.w -t sim 2762ms±8.99 2821ms±16.63 +59ms (+2.13%)🟥
jsii_big.test.w -t tf-aws 2970ms±17.11 3010ms±11.74 +41ms (+1.37%)🟥
functions_1.test.w -t sim 380ms±5.34 388ms±5.92 +8ms (+2.14%)⬜
functions_1.test.w -t tf-aws 811ms±2.93 826ms±7.34 +15ms (+1.9%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 61ms 1ms 1ms
empty.test.w -t sim 352ms 344ms 367ms 5ms 7ms
empty.test.w -t tf-aws 589ms 574ms 598ms 5ms 7ms
hello_world.test.w -t sim 387ms 376ms 399ms 5ms 6ms
hello_world.test.w -t tf-aws 1543ms 1527ms 1596ms 14ms 20ms
functions_10.test.w -t sim 481ms 471ms 494ms 5ms 7ms
functions_10.test.w -t tf-aws 2163ms 2129ms 2186ms 12ms 17ms
jsii_small.test.w -t sim 372ms 366ms 384ms 5ms 7ms
jsii_small.test.w -t tf-aws 613ms 596ms 631ms 8ms 11ms
jsii_big.test.w -t sim 2821ms 2785ms 2865ms 17ms 23ms
jsii_big.test.w -t tf-aws 3010ms 2984ms 3032ms 12ms 16ms
functions_1.test.w -t sim 388ms 373ms 399ms 6ms 8ms
functions_1.test.w -t tf-aws 826ms 810ms 842ms 7ms 10ms
Last Updated (UTC) 2024-03-29 05:09

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 29, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 29, 2024
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @garysassano 🙏

Copy link
Contributor

mergify bot commented Mar 29, 2024

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if gary/fix-s3-empty-file is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 29, 2024
@mergify mergify bot merged commit 390f746 into main Mar 29, 2024
38 of 40 checks passed
@mergify mergify bot deleted the gary/fix-s3-empty-file branch March 29, 2024 19:08
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.66.4.

mergify bot pushed a commit that referenced this pull request Apr 9, 2024
Seems like it was accidentally included from #6091

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown when trying to get an empty file from a bucket on AWS
3 participants