Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): array.slice() #6081

Merged
merged 5 commits into from
Mar 27, 2024
Merged

feat(sdk): array.slice() #6081

merged 5 commits into from
Mar 27, 2024

Conversation

Chriscbr
Copy link
Contributor

Closes #5697

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner March 27, 2024 19:48
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Mar 27, 2024

Console preview environment is available at https://wing-console-pr-6081.fly.dev 🚀

Last Updated (UTC) 2024-03-27 20:04

@monadabot
Copy link
Contributor

monadabot commented Mar 27, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟥🟥⬜⬜⬜
Benchmark Before After Change
version 63ms±2.5 61ms±0.4 -2ms (-2.71%)⬜
empty.test.w -t sim 358ms±6.43 365ms±4.97 +7ms (+1.88%)⬜
empty.test.w -t tf-aws 601ms±6.53 604ms±5.26 +3ms (+0.57%)⬜
hello_world.test.w -t sim 394ms±4.51 401ms±8.11 +7ms (+1.89%)⬜
hello_world.test.w -t tf-aws 1536ms±10.91 1554ms±13.75 +19ms (+1.22%)⬜
functions_10.test.w -t sim 481ms±12.39 473ms±8.68 -9ms (-1.84%)⬜
functions_10.test.w -t tf-aws 2154ms±7.14 2162ms±9.01 +8ms (+0.39%)⬜
jsii_small.test.w -t sim 365ms±2.84 370ms±5.17 +6ms (+1.54%)⬜
jsii_small.test.w -t tf-aws 601ms±4.62 615ms±4.27 +14ms (+2.4%)🟥
jsii_big.test.w -t sim 2787ms±12.41 2815ms±10.92 +28ms (+1.02%)🟥
jsii_big.test.w -t tf-aws 3038ms±11.21 3025ms±8.43 -13ms (-0.41%)⬜
functions_1.test.w -t sim 393ms±3.6 392ms±5.01 -1ms (-0.37%)⬜
functions_1.test.w -t tf-aws 843ms±7.5 837ms±4.73 -6ms (-0.68%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 61ms 60ms 62ms 0ms 1ms
empty.test.w -t sim 365ms 352ms 375ms 5ms 7ms
empty.test.w -t tf-aws 604ms 589ms 613ms 5ms 7ms
hello_world.test.w -t sim 401ms 392ms 427ms 8ms 11ms
hello_world.test.w -t tf-aws 1554ms 1533ms 1599ms 14ms 19ms
functions_10.test.w -t sim 473ms 448ms 490ms 9ms 12ms
functions_10.test.w -t tf-aws 2162ms 2139ms 2182ms 9ms 13ms
jsii_small.test.w -t sim 370ms 362ms 385ms 5ms 7ms
jsii_small.test.w -t tf-aws 615ms 605ms 625ms 4ms 6ms
jsii_big.test.w -t sim 2815ms 2791ms 2836ms 11ms 15ms
jsii_big.test.w -t tf-aws 3025ms 3014ms 3042ms 8ms 12ms
functions_1.test.w -t sim 392ms 379ms 402ms 5ms 7ms
functions_1.test.w -t tf-aws 837ms 824ms 844ms 5ms 7ms
Last Updated (UTC) 2024-03-27 20:09

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 27, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 27, 2024
Copy link
Contributor

mergify bot commented Mar 27, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/array-slice is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 35b8e3a into main Mar 27, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/array-slice branch March 27, 2024 20:13
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.66.1.

//-----------------------------------------------------------------------------
// slice()

test "slice()" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test it on preflight too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array.slice
4 participants