Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tunnels library is not published #6070

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: tunnels library is not published #6070

merged 1 commit into from
Mar 26, 2024

Conversation

eladcon
Copy link
Collaborator

@eladcon eladcon commented Mar 26, 2024

Fixes #6065

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-6070.fly.dev 🚀

Last Updated (UTC) 2024-03-26 12:43

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜
Benchmark Before After Change
version 60ms±0.56 61ms±0.52 +1ms (+2.2%)🟥
empty.test.w -t sim 359ms±4.92 359ms±4.48 +0ms (+0.11%)⬜
empty.test.w -t tf-aws 600ms±5.05 599ms±4.87 -1ms (-0.15%)⬜
hello_world.test.w -t sim 389ms±4.47 403ms±10.03 +14ms (+3.54%)⬜
hello_world.test.w -t tf-aws 1548ms±16.15 1578ms±27.19 +30ms (+1.94%)⬜
functions_10.test.w -t sim 468ms±11.45 478ms±9.64 +11ms (+2.25%)⬜
functions_10.test.w -t tf-aws 2180ms±15.81 2162ms±14.54 -19ms (-0.85%)⬜
jsii_small.test.w -t sim 370ms±6.03 368ms±4.15 -2ms (-0.52%)⬜
jsii_small.test.w -t tf-aws 614ms±3.12 607ms±7.73 -7ms (-1.17%)⬜
jsii_big.test.w -t sim 2827ms±16.22 2835ms±23.44 +8ms (+0.28%)⬜
jsii_big.test.w -t tf-aws 3036ms±12.03 3071ms±15.41 +35ms (+1.14%)🟥
functions_1.test.w -t sim 394ms±4.18 394ms±4.42 0ms (-0.11%)⬜
functions_1.test.w -t tf-aws 830ms±5.18 845ms±9.02 +15ms (+1.77%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 61ms 61ms 63ms 1ms 1ms
empty.test.w -t sim 359ms 352ms 372ms 4ms 6ms
empty.test.w -t tf-aws 599ms 591ms 616ms 5ms 7ms
hello_world.test.w -t sim 403ms 391ms 439ms 10ms 14ms
hello_world.test.w -t tf-aws 1578ms 1553ms 1681ms 27ms 38ms
functions_10.test.w -t sim 478ms 455ms 501ms 10ms 13ms
functions_10.test.w -t tf-aws 2162ms 2136ms 2202ms 15ms 20ms
jsii_small.test.w -t sim 368ms 358ms 376ms 4ms 6ms
jsii_small.test.w -t tf-aws 607ms 592ms 619ms 8ms 11ms
jsii_big.test.w -t sim 2835ms 2794ms 2886ms 23ms 33ms
jsii_big.test.w -t tf-aws 3071ms 3036ms 3100ms 15ms 22ms
functions_1.test.w -t sim 394ms 384ms 402ms 4ms 6ms
functions_1.test.w -t tf-aws 845ms 829ms 877ms 9ms 13ms
Last Updated (UTC) 2024-03-26 12:48

Copy link
Contributor

mergify bot commented Mar 26, 2024

Thanks for contributing, @eladcon! This PR will now be added to the merge queue, or immediately merged if publish-tunnels is up-to-date with main and the queue is empty.

@eladcon eladcon marked this pull request as ready for review March 26, 2024 13:32
@eladcon eladcon requested a review from a team as a code owner March 26, 2024 13:32
@mergify mergify bot merged commit 9473b8d into main Mar 26, 2024
16 checks passed
@mergify mergify bot deleted the publish-tunnels branch March 26, 2024 13:33
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.64.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@winglang/wingtunnels is not published to npm
3 participants