Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: sunset ex.DynamodbTable #6038

Merged
merged 4 commits into from
Mar 22, 2024
Merged

feat(sdk)!: sunset ex.DynamodbTable #6038

merged 4 commits into from
Mar 22, 2024

Conversation

Chriscbr
Copy link
Contributor

The Wing library ecosystem is steadily growing, and we now have a dedicated winglib for DynamoDB, which you can use with:

bring dynamodb;

It supports both the sim and tf-aws targets, and includes newly added support for DynamoDB streams. To lighten our maintenance load (and build times), this PR removes the built-in ex.DynamodbTable class from the core Wing SDK.

If you have any troubles with the new dedicated winglib, please let us know by opening an issue or sending a message on the Wing slack - we're happy to help.

BREAKING CHANGE: ex.DynamodbTable and related types have been removed from the built-in SDK. We recommend using the dedicated dynamodb winglib instead.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr changed the title feat(sdk): sunset ex.DynamodbTable feat(sdk): sunset ex.DynamodbTable Mar 21, 2024
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@Chriscbr Chriscbr changed the title feat(sdk): sunset ex.DynamodbTable feat(sdk)!: sunset ex.DynamodbTable Mar 21, 2024
@monadabot
Copy link
Contributor

monadabot commented Mar 21, 2024

Console preview environment is available at https://wing-console-pr-6038.fly.dev 🚀

Last Updated (UTC) 2024-03-21 21:58

@monadabot
Copy link
Contributor

monadabot commented Mar 21, 2024

Benchmarks

Comparison to Baseline 🟥🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩
Benchmark Before After Change
version 57ms±0.35 60ms±0.9 +2ms (+4.25%)🟥
empty.test.w -t sim 521ms±40.3 352ms±4.26 -168ms (-32.3%)🟩
empty.test.w -t tf-aws 696ms±3.25 590ms±6.82 -107ms (-15.32%)🟩
hello_world.test.w -t sim 516ms±4.35 393ms±4.89 -124ms (-23.94%)🟩
hello_world.test.w -t tf-aws 1637ms±6.23 1537ms±19.82 -100ms (-6.11%)🟩
functions_10.test.w -t sim 589ms±8.42 462ms±7.41 -127ms (-21.53%)🟩
functions_10.test.w -t tf-aws 2213ms±9.48 2139ms±11.93 -74ms (-3.36%)🟩
jsii_small.test.w -t sim 486ms±4.56 359ms±3.71 -127ms (-26.11%)🟩
jsii_small.test.w -t tf-aws 708ms±6.41 602ms±3.59 -106ms (-14.99%)🟩
jsii_big.test.w -t sim 2888ms±9.62 2777ms±12.7 -112ms (-3.87%)🟩
jsii_big.test.w -t tf-aws 3085ms±9.76 2973ms±9.91 -112ms (-3.65%)🟩
functions_1.test.w -t sim 515ms±4.7 382ms±6.21 -133ms (-25.77%)🟩
functions_1.test.w -t tf-aws 937ms±6.72 822ms±5.36 -115ms (-12.25%)🟩

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 58ms 62ms 1ms 1ms
empty.test.w -t sim 352ms 341ms 361ms 4ms 6ms
empty.test.w -t tf-aws 590ms 572ms 604ms 7ms 10ms
hello_world.test.w -t sim 393ms 385ms 406ms 5ms 7ms
hello_world.test.w -t tf-aws 1537ms 1509ms 1604ms 20ms 28ms
functions_10.test.w -t sim 462ms 447ms 475ms 7ms 10ms
functions_10.test.w -t tf-aws 2139ms 2114ms 2164ms 12ms 17ms
jsii_small.test.w -t sim 359ms 349ms 365ms 4ms 5ms
jsii_small.test.w -t tf-aws 602ms 595ms 611ms 4ms 5ms
jsii_big.test.w -t sim 2777ms 2753ms 2810ms 13ms 18ms
jsii_big.test.w -t tf-aws 2973ms 2952ms 2993ms 10ms 14ms
functions_1.test.w -t sim 382ms 370ms 397ms 6ms 9ms
functions_1.test.w -t tf-aws 822ms 811ms 834ms 5ms 7ms
Last Updated (UTC) 2024-03-21 22:03

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 21, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 22, 2024
Copy link
Contributor

mergify bot commented Mar 22, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/sunset-dynamodb is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit f113593 into main Mar 22, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/sunset-dynamodb branch March 22, 2024 16:31
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.63.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants