-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): aws.QueueRef
#6001
feat(sdk): aws.QueueRef
#6001
Conversation
Introduce `aws.QueueRef` as a way to add an external queue reference to an application: bring aws; bring cloud; let myQueue = new aws.QueueRef("arn:aws:sqs:...."); // <-- ARN of an existing SQS queue new cloud.Function(inflight () => { myQueue.push("new message"); }); This works both when running in the simulator and when running on AWS. The Wing Console also includes some metadata about the queue such as the queue URL and the AWS Console URL: ### Misc Added an option `link: bool` to `ui.FIeld` to indicate that the value returned is a link. We should make this a clickable link in the Wing Console.
Thanks for opening this pull request! 🎉
|
BenchmarksComparison to Baseline 🟥⬜🟥🟥⬜⬜⬜⬜🟩⬜🟩🟩🟩
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-03-19 18:38 |
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Console preview environment is available at https://wing-console-pr-6001.fly.dev 🚀 Last Updated (UTC) 2024-03-19 18:32 |
Is this a one-off solution for the related issue of referencing existing infra or is this intended to be the pattern to follow going forward? Side note on the benchmark regressions: I'm willing to bet the additional ~90ms added to all the sim compilations are the imports added to |
So firstly this is fucking cool, especially what it does in the console 🔥 Thinking out loud here... What about organizing these reference classes under a let outbox = new aws.reference.Queue("arn..."); |
@MarkMcCulloh asked:
This is intended to be the pattern going forward for all external references, so we will have |
@hasanaburayyan suggested:
I am a flat lists and prefixes over namespace hierarchies as it's dramatically improves discoverability. |
@MarkMcCulloh, what would you recommend to do about the performance regressions (amazing that this was caught)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Im excited about this direction
Signed-off-by: monada-bot[bot] <[email protected]>
Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.61.22. |
Introduce
aws.QueueRef
as a way to add an external queue reference to an application:This works both when running in the simulator and when running on AWS.
The Wing Console also includes some metadata about the queue such as the queue URL and the AWS Console URL:
Issues
Misc
Added an option
link: bool
toui.FIeld
to indicate that the value returned is a link. We should make this a clickable link in the Wing Console.Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.