Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): react vite template failed when running in windows #5997

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ainvoner
Copy link
Contributor

vite resource wasn't working windows

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@ainvoner ainvoner requested a review from a team as a code owner March 19, 2024 13:28
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜🟥🟥⬜⬜🟥⬜⬜
Benchmark Before After Change
version 63ms±2.52 58ms±0.56 -4ms (-6.6%)⬜
empty.test.w -t sim 484ms±4.26 481ms±7.59 -3ms (-0.69%)⬜
empty.test.w -t tf-aws 702ms±9.14 705ms±4.73 +3ms (+0.4%)⬜
hello_world.test.w -t sim 513ms±5.07 523ms±14.91 +10ms (+1.91%)⬜
hello_world.test.w -t tf-aws 1650ms±15.12 1656ms±15.44 +5ms (+0.33%)⬜
functions_10.test.w -t sim 592ms±7.37 599ms±11.45 +7ms (+1.24%)⬜
functions_10.test.w -t tf-aws 2216ms±12.47 2265ms±19.64 +49ms (+2.22%)🟥
jsii_small.test.w -t sim 484ms±5.38 500ms±3.75 +15ms (+3.14%)🟥
jsii_small.test.w -t tf-aws 706ms±4.88 715ms±5.17 +9ms (+1.25%)⬜
jsii_big.test.w -t sim 2894ms±9.31 2931ms±18.19 +37ms (+1.28%)⬜
jsii_big.test.w -t tf-aws 3096ms±12.05 3136ms±8.17 +40ms (+1.28%)🟥
functions_1.test.w -t sim 514ms±4.41 519ms±4.3 +5ms (+0.98%)⬜
functions_1.test.w -t tf-aws 943ms±8.34 953ms±7.88 +11ms (+1.12%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 57ms 60ms 1ms 1ms
empty.test.w -t sim 481ms 468ms 505ms 8ms 11ms
empty.test.w -t tf-aws 705ms 691ms 713ms 5ms 7ms
hello_world.test.w -t sim 523ms 503ms 578ms 15ms 21ms
hello_world.test.w -t tf-aws 1656ms 1625ms 1693ms 15ms 22ms
functions_10.test.w -t sim 599ms 584ms 637ms 11ms 16ms
functions_10.test.w -t tf-aws 2265ms 2209ms 2298ms 20ms 27ms
jsii_small.test.w -t sim 500ms 493ms 509ms 4ms 5ms
jsii_small.test.w -t tf-aws 715ms 701ms 730ms 5ms 7ms
jsii_big.test.w -t sim 2931ms 2881ms 2976ms 18ms 25ms
jsii_big.test.w -t tf-aws 3136ms 3118ms 3158ms 8ms 11ms
functions_1.test.w -t sim 519ms 512ms 531ms 4ms 6ms
functions_1.test.w -t tf-aws 953ms 934ms 969ms 8ms 11ms
Last Updated (UTC) 2024-03-19 13:37

Copy link
Contributor

mergify bot commented Mar 19, 2024

Thanks for contributing, @ainvoner! This PR will now be added to the merge queue, or immediately merged if react-vite/fix-windows-path is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit ee559b9 into main Mar 19, 2024
16 checks passed
@mergify mergify bot deleted the react-vite/fix-windows-path branch March 19, 2024 13:38
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants