Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (ed54e0c) and #5935 together #5990

Closed
wants to merge 43 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (ed54e0c) and #5935 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #5935.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

Required conditions to stay in the queue:

Visit the Mergify Dashboard to check the state of the queue default.

---
previous_failed_batches: []
pull_requests:
  - number: 5935
...

yoav-steinberg and others added 30 commits March 11, 2024 09:36
Correctly calculate the phase of array literals (allowing phase independent arrays).
Signed-off-by: monada-bot[bot] <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.58 58ms±0.61 +1ms (+1.1%)⬜
empty.test.w -t sim 507ms±26.33 484ms±4.45 -23ms (-4.54%)⬜
empty.test.w -t tf-aws 700ms±3.49 704ms±11.08 +5ms (+0.71%)⬜
hello_world.test.w -t sim 509ms±3.35 526ms±14.13 +17ms (+3.28%)⬜
hello_world.test.w -t tf-aws 1627ms±11.62 1642ms±15.08 +14ms (+0.88%)⬜
functions_10.test.w -t sim 590ms±6.21 593ms±5.98 +3ms (+0.48%)⬜
functions_10.test.w -t tf-aws 2208ms±17.23 2207ms±8.55 -1ms (-0.02%)⬜
jsii_small.test.w -t sim 487ms±4.31 483ms±4.6 -4ms (-0.77%)⬜
jsii_small.test.w -t tf-aws 703ms±2.87 704ms±6.17 +1ms (+0.13%)⬜
jsii_big.test.w -t sim 2875ms±7.76 2879ms±12.26 +4ms (+0.13%)⬜
jsii_big.test.w -t tf-aws 3081ms±10.29 3087ms±8.35 +7ms (+0.21%)⬜
functions_1.test.w -t sim 507ms±3.87 510ms±4.25 +3ms (+0.57%)⬜
functions_1.test.w -t tf-aws 934ms±3.9 939ms±4.39 +6ms (+0.59%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 57ms 60ms 1ms 1ms
empty.test.w -t sim 484ms 478ms 498ms 4ms 6ms
empty.test.w -t tf-aws 704ms 683ms 742ms 11ms 15ms
hello_world.test.w -t sim 526ms 507ms 574ms 14ms 20ms
hello_world.test.w -t tf-aws 1642ms 1622ms 1692ms 15ms 21ms
functions_10.test.w -t sim 593ms 575ms 603ms 6ms 8ms
functions_10.test.w -t tf-aws 2207ms 2193ms 2235ms 9ms 12ms
jsii_small.test.w -t sim 483ms 472ms 492ms 5ms 6ms
jsii_small.test.w -t tf-aws 704ms 688ms 711ms 6ms 9ms
jsii_big.test.w -t sim 2879ms 2853ms 2907ms 12ms 17ms
jsii_big.test.w -t tf-aws 3087ms 3063ms 3104ms 8ms 12ms
functions_1.test.w -t sim 510ms 501ms 519ms 4ms 6ms
functions_1.test.w -t tf-aws 939ms 930ms 948ms 4ms 6ms
Last Updated (UTC) 2024-03-19 07:43

@mergify mergify bot closed this Mar 19, 2024
@mergify mergify bot deleted the mergify/merge-queue/53240c1964 branch March 19, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants