Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): react vite template #5969

Merged
merged 9 commits into from
Mar 18, 2024
Merged

feat(cli): react vite template #5969

merged 9 commits into from
Mar 18, 2024

Conversation

ainvoner
Copy link
Contributor

Part of react-vite use case.
Based on react-vite-websockets wing workshop.
resolves: #5928

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Mar 18, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 63ms±2.99 61ms±0.94 -2ms (-3.65%)⬜
empty.test.w -t sim 491ms±5.32 499ms±6.58 +8ms (+1.7%)⬜
empty.test.w -t tf-aws 715ms±5.55 721ms±5.19 +5ms (+0.73%)⬜
hello_world.test.w -t sim 528ms±6.69 535ms±11.52 +8ms (+1.46%)⬜
hello_world.test.w -t tf-aws 1670ms±18.03 1680ms±23.17 +10ms (+0.58%)⬜
functions_10.test.w -t sim 602ms±7.53 606ms±6.02 +4ms (+0.67%)⬜
functions_10.test.w -t tf-aws 2267ms±11.44 2288ms±8.46 +21ms (+0.93%)⬜
jsii_small.test.w -t sim 506ms±4.33 503ms±4.62 -3ms (-0.6%)⬜
jsii_small.test.w -t tf-aws 723ms±5.47 726ms±6.73 +3ms (+0.36%)⬜
jsii_big.test.w -t sim 2933ms±7.11 2940ms±8.01 +7ms (+0.25%)⬜
jsii_big.test.w -t tf-aws 3145ms±6.63 3154ms±8.61 +9ms (+0.29%)⬜
functions_1.test.w -t sim 522ms±3.71 532ms±8.46 +9ms (+1.76%)⬜
functions_1.test.w -t tf-aws 964ms±6.23 964ms±5.69 0ms (-0.03%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 61ms 59ms 64ms 1ms 1ms
empty.test.w -t sim 499ms 483ms 509ms 7ms 9ms
empty.test.w -t tf-aws 721ms 712ms 733ms 5ms 7ms
hello_world.test.w -t sim 535ms 520ms 572ms 12ms 16ms
hello_world.test.w -t tf-aws 1680ms 1657ms 1765ms 23ms 32ms
functions_10.test.w -t sim 606ms 595ms 625ms 6ms 8ms
functions_10.test.w -t tf-aws 2288ms 2267ms 2303ms 8ms 12ms
jsii_small.test.w -t sim 503ms 492ms 514ms 5ms 6ms
jsii_small.test.w -t tf-aws 726ms 715ms 746ms 7ms 9ms
jsii_big.test.w -t sim 2940ms 2921ms 2956ms 8ms 11ms
jsii_big.test.w -t tf-aws 3154ms 3137ms 3179ms 9ms 12ms
functions_1.test.w -t sim 532ms 516ms 556ms 8ms 12ms
functions_1.test.w -t tf-aws 964ms 950ms 973ms 6ms 8ms
Last Updated (UTC) 2024-03-18 10:32

@ainvoner ainvoner marked this pull request as ready for review March 18, 2024 09:32
@ainvoner ainvoner requested a review from a team as a code owner March 18, 2024 09:32
@ainvoner ainvoner requested a review from skyrpex March 18, 2024 10:24
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thanks for contributing, @ainvoner! This PR will now be added to the merge queue, or immediately merged if react-vite-template is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 18, 2024
@mergify mergify bot merged commit a361e81 into main Mar 18, 2024
15 checks passed
@mergify mergify bot deleted the react-vite-template branch March 18, 2024 10:43
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add react-vite template to Wing cli
3 participants