feat: generate types for extern declarations
#5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉
|
|
Console preview environment is available at https://wing-console-pr-5967.fly.dev 🚀 Last Updated (UTC) 2024-03-17 20:32 |
BenchmarksComparison to Baseline 🟥🟥⬜⬜🟥⬜🟥⬜🟥⬜⬜🟥⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-03-17 20:37 |
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
added
🧪 pr/e2e-full
and removed
🧪 pr/e2e-full
⚠️ pr/review-mutation
eladb
approved these changes
Mar 18, 2024
|
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
14 tasks
|
Congrats! 🚀 This was released in Wing 0.61.13. |
Chriscbr
reviewed
Mar 19, 2024
| @@ -4,7 +4,7 @@ class MyResource { | |||
| api: cloud.Api; | |||
| url: str; | |||
|
|
|||
| extern "./url_utils.js" pub static inflight isValidUrl(url: str): bool; | |||
| extern "./url_utils.ts" pub static inflight isValidUrl(url: str): bool; | |||
There was a problem hiding this comment.
@MarkMcCulloh Just checking, so we've decided to officially support *.ts files? Should we note this in the documentation or language spec somewhere? (I'm cool with the choice, just wanna check if we're tracking it somewhere :^))
Chriscbr
reviewed
Mar 19, 2024
| pub fn is_extern_file(file: &Utf8PathBuf) -> bool { | ||
| if let Some(ext) = file.extension() { | ||
| match ext { | ||
| "js" | "cjs" | "mjs" | "jsx" | "ts" | "cts" | "mts" | "tsx" => true, |
There was a problem hiding this comment.
Who woulda thunk a single language would result in so many file extensions / formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5868 (except the static part, but that's not critical for the use-case)
Compiling a wing project will now generate .d.ts files for the contract between wing and extern files. These .d.ts files are fully self-contained.
The code for this looks similar to existing dtsification code, but there are couple important distinctions that made it feel useful to separate it:
Misc:
examplesexterns into typescript (I would love to do the rest, but need Using ESM in external preflight function fails #3013)Note that this may be a breaking change: extern types must be consistent. So in one class you refer to an extern as returning a
strand in another it returns a Json, that will now be a compiler error.By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.