Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): popping queue in aws can sometimes throw #4919

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

MarkMcCulloh
Copy link
Contributor

See https://github.com/winglang/wing/actions/runs/6853870493/job/18635846024

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner November 13, 2023 19:14
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4919.fly.dev 🚀

Last Updated (UTC) 2023-11-13 19:21

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 68ms±0.36 70ms±0.97 +2ms (+3.38%)🟥
jsii_small.test.w -t sim 520ms±3.16 523ms±8.52 +3ms (+0.61%)⬜
jsii_small.test.w -t tf-aws 643ms±4.88 642ms±4.46 -1ms (-0.16%)⬜
functions_1.test.w -t sim 549ms±8.36 550ms±6.26 +1ms (+0.16%)⬜
functions_1.test.w -t tf-aws 1513ms±44.64 1521ms±30.28 +8ms (+0.52%)⬜
hello_world.test.w -t sim 546ms±6.47 549ms±5.72 +3ms (+0.63%)⬜
hello_world.test.w -t tf-aws 3993ms±32.34 4026ms±36.48 +33ms (+0.82%)⬜
jsii_big.test.w -t sim 3365ms±7.88 3373ms±10.05 +8ms (+0.23%)⬜
jsii_big.test.w -t tf-aws 3479ms±14.59 3467ms±10.76 -12ms (-0.34%)⬜
functions_10.test.w -t sim 599ms±6.25 599ms±3.62 +0ms (+0.03%)⬜
functions_10.test.w -t tf-aws 3185ms±39.71 3229ms±29.85 +44ms (+1.37%)⬜
empty.test.w -t sim 518ms±5.47 519ms±12.6 +1ms (+0.11%)⬜
empty.test.w -t tf-aws 639ms±1.71 643ms±4.02 +4ms (+0.63%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 70ms 69ms 73ms 1ms 1ms
jsii_small.test.w -t sim 523ms 508ms 542ms 9ms 12ms
jsii_small.test.w -t tf-aws 642ms 630ms 650ms 4ms 6ms
functions_1.test.w -t sim 550ms 539ms 571ms 6ms 9ms
functions_1.test.w -t tf-aws 1521ms 1443ms 1581ms 30ms 42ms
hello_world.test.w -t sim 549ms 536ms 562ms 6ms 8ms
hello_world.test.w -t tf-aws 4026ms 3973ms 4152ms 36ms 51ms
jsii_big.test.w -t sim 3373ms 3345ms 3393ms 10ms 14ms
jsii_big.test.w -t tf-aws 3467ms 3448ms 3497ms 11ms 15ms
functions_10.test.w -t sim 599ms 594ms 611ms 4ms 5ms
functions_10.test.w -t tf-aws 3229ms 3155ms 3303ms 30ms 42ms
empty.test.w -t sim 519ms 502ms 561ms 13ms 18ms
empty.test.w -t tf-aws 643ms 633ms 651ms 4ms 6ms
Last Updated (UTC) 2023-11-13 19:29

Copy link
Contributor

mergify bot commented Nov 13, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/queue-pop-fix is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit d8fa0a7 into main Nov 13, 2023
15 checks passed
@mergify mergify bot deleted the mark/queue-pop-fix branch November 13, 2023 19:38
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.47.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants