Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add Assert.throws #4461

Closed
wants to merge 3 commits into from
Closed

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 8, 2023

Part of #1977

This PR adds Assert.throws in /examples/tests/valid/assertions.w.
Since phase-independent class/function is not supported yet (see #435 #1711), PreflightAssert.throws is added too.
It should be merged into Assert.throws once phase-independency is supported.

/example/tests/**/*.test.w are now refactored to use (Preflight)Assert.throws as much as possible.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@exoego exoego marked this pull request as ready for review October 8, 2023 13:15
@exoego exoego requested a review from a team as a code owner October 8, 2023 13:15
@garysassano
Copy link
Collaborator

This feature should be part of the testing module, which still hasn't been implemented: #3976

@exoego exoego closed this Oct 9, 2023
@exoego exoego deleted the assert-throws branch October 23, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants