Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): remove TODO comment from std.Duration tests #4366

Closed
wants to merge 1 commit into from

Conversation

garysassano
Copy link
Collaborator

Closes #2962

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner October 1, 2023 23:39
@tsuf239
Copy link
Collaborator

tsuf239 commented Oct 2, 2023

It seems like there are still more tests to write here duration.fromXXX(10).hours for example....
So leaving the comment there may be the right thing to do, thank you for noticing! 💪

@tsuf239 tsuf239 closed this Oct 2, 2023
@WeepingClown13 WeepingClown13 deleted the garysassano/sdk-tests-duration branch October 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duration std tests
2 participants