Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (65124f1) and #4344 together #4347

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 29, 2023

🎉 This pull request has been checked successfully and will be merged. 🎉

Branch main (65124f1) and #4344 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4344.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

Required conditions to stay in the queue:

Visit the Mergify Dashboard to check the state of the queue default.


More information about Mergify merge queue can be found in the documentation.

Mergify commands

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the queue rules

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

---
pull_requests:
  - number: 4344
...

@monadabot
Copy link
Contributor

Benchmarks

Results
name mean min max moe sd
version 89ms 85ms 93ms 3ms 4ms
functions_10.test.w -t sim 761ms 740ms 813ms 11ms 19ms
functions_10.test.w -t tf-aws 4641ms 4555ms 4764ms 27ms 48ms
jsii_big.test.w -t sim 4412ms 4349ms 4496ms 26ms 48ms
jsii_big.test.w -t tf-aws 4591ms 4514ms 4685ms 27ms 49ms
hello_world.test.w -t sim 678ms 654ms 701ms 7ms 13ms
hello_world.test.w -t tf-aws 5523ms 5388ms 5638ms 41ms 75ms
empty.test.w -t sim 627ms 601ms 664ms 9ms 16ms
empty.test.w -t tf-aws 790ms 766ms 845ms 11ms 19ms
jsii_small.test.w -t sim 626ms 608ms 651ms 7ms 13ms
jsii_small.test.w -t tf-aws 797ms 776ms 830ms 8ms 15ms
functions_1.test.w -t sim 707ms 681ms 742ms 10ms 18ms
functions_1.test.w -t tf-aws 2485ms 2291ms 2615ms 46ms 83ms
Comparison to main
Benchmark Before After Change
version 102ms±4.02 89ms±2.66 -13ms (-12.53%)🟩
functions_10.test.w -t sim 894ms±13.74 761ms±10.72 -133ms (-14.89%)🟩
functions_10.test.w -t tf-aws 5388ms±45.1 4641ms±26.56 -747ms (-13.86%)🟩
jsii_big.test.w -t sim 4895ms±59.82 4412ms±26.31 -484ms (-9.88%)🟩
jsii_big.test.w -t tf-aws 5176ms±73.13 4591ms±27.3 -585ms (-11.3%)🟩
hello_world.test.w -t sim 743ms±8.22 678ms±7.38 -65ms (-8.77%)🟩
hello_world.test.w -t tf-aws 6105ms±49.85 5523ms±41.49 -583ms (-9.54%)🟩
empty.test.w -t sim 679ms±7.25 627ms±8.88 -51ms (-7.59%)🟩
empty.test.w -t tf-aws 876ms±10.97 790ms±10.53 -86ms (-9.85%)🟩
jsii_small.test.w -t sim 698ms±8.88 626ms±7.44 -72ms (-10.27%)🟩
jsii_small.test.w -t tf-aws 871ms±11.34 797ms±8.46 -74ms (-8.46%)🟩
functions_1.test.w -t sim 776ms±13.39 707ms±9.79 -69ms (-8.94%)🟩
functions_1.test.w -t tf-aws 2723ms±62.36 2485ms±46.01 -238ms (-8.75%)🟩
Last Updated (UTC) 2023-09-29 22:51

@mergify mergify bot closed this Sep 29, 2023
@mergify mergify bot deleted the mergify/merge-queue/3521f819fa branch September 29, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants