-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): maintainers can run sdk spec tests on forks #4322
Conversation
This should be a "chore" because it's not a new feature of winglang. |
Co-authored-by: Mark McCulloh <[email protected]>
….com/winglang/wing into tsuf/running-sdk-spec-tests-on-forks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than removing the hardcoded usernames, LGTM
Co-authored-by: Mark McCulloh <[email protected]>
….com/winglang/wing into tsuf/running-sdk-spec-tests-on-forks
Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.34.6. |
fixes #4139
https://www.loom.com/share/5b33e2635ed04be2a8502d7fc5f1116f
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.