Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): maintainers can run sdk spec tests on forks #4322

Merged
merged 22 commits into from
Oct 1, 2023

Conversation

tsuf239
Copy link
Collaborator

@tsuf239 tsuf239 commented Sep 28, 2023

fixes #4139
https://www.loom.com/share/5b33e2635ed04be2a8502d7fc5f1116f

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@tsuf239 tsuf239 requested a review from a team as a code owner September 28, 2023 11:38
.github/workflows/tf-aws-test.yml Outdated Show resolved Hide resolved
.github/workflows/tf-aws-test.yml Show resolved Hide resolved
.github/workflows/tf-aws-test.yml Outdated Show resolved Hide resolved
@eladb
Copy link
Contributor

eladb commented Sep 30, 2023

This should be a "chore" because it's not a new feature of winglang.

@tsuf239 tsuf239 changed the title feat(repo): maintainers can run sdk spec tests on forks chore(repo): maintainers can run sdk spec tests on forks Oct 1, 2023
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than removing the hardcoded usernames, LGTM

.github/workflows/tf-aws-test.yml Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2023

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/running-sdk-spec-tests-on-forks is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 1, 2023
@mergify mergify bot merged commit def4257 into main Oct 1, 2023
12 checks passed
@mergify mergify bot deleted the tsuf/running-sdk-spec-tests-on-forks branch October 1, 2023 15:49
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an ability specify tests in the PR and run it on our sdk gh action
5 participants