Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): added tests to std.Range #4281

Merged
merged 6 commits into from
Oct 4, 2023
Merged

feat(sdk): added tests to std.Range #4281

merged 6 commits into from
Oct 4, 2023

Conversation

revitalbarletz
Copy link
Contributor

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@revitalbarletz revitalbarletz requested a review from a team as a code owner September 26, 2023 12:02
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 26, 2023
@WeepingClown13 WeepingClown13 changed the title feat(sdk): Added tests to std.Range feat(sdk): added tests to std.Range Sep 26, 2023
@WeepingClown13
Copy link
Collaborator

@revitalbarletz I modified the pr title ever so slightly to satisfy the linter.

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 1, 2023
@WeepingClown13 WeepingClown13 mentioned this pull request Oct 2, 2023
Closed
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 2, 2023
@garysassano
Copy link
Collaborator

You could add a range with the same number: std.Range.of(x, x)

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 4, 2023
@tsuf239
Copy link
Collaborator

tsuf239 commented Oct 4, 2023 •
edited
Loading

You could add a range with the same number: std.Range.of(x, x)

That's a great idea!

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

Thanks for contributing, @revitalbarletz! This PR will now be added to the merge queue, or immediately merged if revitalb-range-tests is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 4, 2023
@mergify
Merge of #4281
9e783c7
@mergify mergify bot mentioned this pull request Oct 4, 2023
Closed
14 tasks
@mergify mergify bot merged commit af4f4f5 into main Oct 4, 2023
15 checks passed
@mergify mergify bot deleted the revitalb-range-tests branch October 4, 2023 11:16
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuf239 tsuf239 tsuf239 approved these changes

@WeepingClown13 WeepingClown13 WeepingClown13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@revitalbarletz @WeepingClown13 @garysassano @tsuf239 @monadabot