-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): cherrypick default az for wing app #4151
Conversation
Console preview environment is available at https://wing-console-pr-4151.fly.dev 🚀 Updated (UTC): 2023-09-19 09:39 |
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garysassano thanks for the fix, curious did you get a chance to try deploying to AWS with this change?
Side note: I think this is the right approach to fix the bug Sebastian ran into, but I think eventually we need to rethink the approach, creating this simple VPC on the user's behalf is great but we need to offer the user a way to customize their VPC. (something easier than using a Wing plugin)
@hasanaburayyan I tested the code and it works. For the future, I think Wing will have to provide some external network modules that are cloud-specific (something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garysassano thanks for the fix!
Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if |
Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.31.5. |
Currently, when a new Wing app is created for AWS targets, it's left up to AWS to choose a random AZ in which to deploy the private and public subnets. With this change, we tell AWS that we always want to deploy to the first AZ of whatever region specified by the user, which is generally the one that has the broadest range of services available.
Closes #4126
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.