Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): cherrypick default az for wing app #4151

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

garysassano
Copy link
Collaborator

Currently, when a new Wing app is created for AWS targets, it's left up to AWS to choose a random AZ in which to deploy the private and public subnets. With this change, we tell AWS that we always want to deploy to the first AZ of whatever region specified by the user, which is generally the one that has the broadest range of services available.

Closes #4126

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner September 11, 2023 19:56
@monadabot
Copy link
Contributor

monadabot commented Sep 11, 2023

Console preview environment is available at https://wing-console-pr-4151.fly.dev 🚀

Updated (UTC): 2023-09-19 09:39

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 11, 2023
Copy link
Contributor

@hasanaburayyan hasanaburayyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garysassano thanks for the fix, curious did you get a chance to try deploying to AWS with this change?

Side note: I think this is the right approach to fix the bug Sebastian ran into, but I think eventually we need to rethink the approach, creating this simple VPC on the user's behalf is great but we need to offer the user a way to customize their VPC. (something easier than using a Wing plugin)

@garysassano
Copy link
Collaborator Author

garysassano commented Sep 12, 2023

@hasanaburayyan I tested the code and it works. For the future, I think Wing will have to provide some external network modules that are cloud-specific (something like ex.AWSNetwork, ex.GCPNetwork, etc.) which allow you to customize where your Wing app resources are created.

Copy link
Contributor

@hasanaburayyan hasanaburayyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garysassano thanks for the fix!

@staycoolcall911 staycoolcall911 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/fix-redis-az is up-to-date with main and the queue is empty.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/fix-redis-az is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 3db16c1 into main Sep 19, 2023
14 checks passed
@mergify mergify bot deleted the garysassano/fix-redis-az branch September 19, 2023 09:52
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.31.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis can't be tested in tf-aws / us-east-1
4 participants