fix(sdk): removing aws-sdk v3 from bundling #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Console preview environment is available at https://wing-console-pr-4109.fly.dev 🚀 Updated (UTC): 2023-09-06 20:14 |
staycoolcall911
approved these changes
Sep 6, 2023
|
Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if |
|
Congrats! 🚀 This was released in Wing 0.29.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundling is configured for Node.js 16 (pointing to
aws-sdkv2 as an external library), but we are configuring our functions on AWS with Node.js 18, which already includesaws-sdkv3.Our entire implementation is using version 3 of
aws-sdk, so I am updating the bundling to use Node.js 18 and marking@aws-sdkas an external library.from this
to this
Close #4103
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.