Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): string interpolation of Json is inconsistent #4044

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Sep 1, 2023

Fixes #3088
Fixes #3987
Fixes #3988

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner September 1, 2023 19:17
@Chriscbr Chriscbr changed the title fix(compiler): string interpolation of Json calls Json.stringify fix(compiler): string interpolation of Json is inconsistent Sep 1, 2023
@monadabot
Copy link
Contributor

monadabot commented Sep 1, 2023

Console preview environment is available at https://wing-console-pr-4044.fly.dev 🚀

Updated (UTC): 2023-09-01 19:39

Copy link
Contributor

@hasanaburayyan hasanaburayyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea lets end the confusion 😁 and 🚢 it

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 1, 2023
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/json-interp is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 7f28718 into main Sep 1, 2023
12 checks passed
@mergify mergify bot deleted the rybickic/json-interp branch September 1, 2023 19:54
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.28.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants