Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): no need to generate tree-sitter wasm as part of build #4041

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Sep 1, 2023

Generating the .wasm for the grammar is only needed when running the tree-sitter playground, otherwise the rust build handles consuming the C files when targeting wasm32-wasi. Skipping this unnecessary work is much faster and removes a pretty big dependency from our core build path (docker, although it's still used in tests)

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner September 1, 2023 13:08
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4041.fly.dev 🚀

Updated (UTC): 2023-09-01 13:15

Copy link
Contributor

@hasanaburayyan hasanaburayyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/tree-sitter-wasm-thing is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 0858dd8 into main Sep 1, 2023
16 checks passed
@mergify mergify bot deleted the mark/tree-sitter-wasm-thing branch September 1, 2023 13:54
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.28.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants