Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): quality gate must run even if e2e tests are skipped #4019

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

A regression from #3791

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner August 30, 2023 16:13
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4019.fly.dev 🚀

Updated (UTC): 2023-08-30 16:23

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/run-even-if-skipped is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 30, 2023
@mergify mergify bot merged commit babdb53 into main Aug 30, 2023
12 checks passed
@mergify mergify bot deleted the mark/run-even-if-skipped branch August 30, 2023 16:55
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.27.6.

mergify bot pushed a commit that referenced this pull request Sep 5, 2023
…ped (#4085)

Similar to #4019, but I didn't realize the issue also applies to any jobs that also has dependencies whose dependencies are skipped.

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants