Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): use arm64 for awscdk and tf-aws functions #3963

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Aug 25, 2023

This change should give better price/performance for most workloads, and not have any effect on runtime behavior since all cloud functions are using the AWS-provided NodeJS runtimes.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner August 25, 2023 01:59
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 25, 2023
@marciocadev
Copy link
Collaborator

I went to check if all regions are already with the arm64 (about 1 year ago there wasn't here in Brazil yet), but apparently all regions are already available.

I think this PR is great.

@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/arm64 is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit dd9055c into main Aug 25, 2023
11 checks passed
@mergify mergify bot deleted the rybickic/arm64 branch August 25, 2023 15:07
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.26.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants