feat(cli): wing pack
#3938
Merged
feat(cli): wing pack
#3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
commented
Aug 23, 2023
Chriscbr
commented
Aug 23, 2023
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
reviewed
Oct 4, 2023
Chriscbr
removed
the
⚠️ pr/review-mutation
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
removed
the
⚠️ pr/review-mutation
|
Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if |
eladb
reviewed
Oct 5, 2023
| throw new Error(`No package.json found in the current directory. Run \`npm init\` first.`); | ||
| } | ||
|
|
||
| const pkgJson = JSON.parse(await fs.readFile(pkgJsonPath, "utf8")); |
There was a problem hiding this comment.
Why read the file again? Isn't this the same as the originalJsonFile above?
|
Congrats! 🚀 This was released in Wing 0.35.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
wing packcommand - a standard way to package libraries in Wing.wing packcan be run in any Wing project directory that has apackage.jsonin it.wing packwill validate yourpackage.jsonproduce a tarball that contains the libraries source files. For more documentation, see https://winglang.io/docs/libraries.Implementation
When you
bring "foo", the parser now performs some Node module resolution to look up thefoopackage and see if it's a JSII library or a Wing library based on itspackage.json. Ifbring "foo"refers to a Wing library, then it's equivalent to bringing that library's root directory, per #4210.Future related work
pubkeyword #4294rediswinglib #2171Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.