Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add MutArray.popAt() and MutArray.removeFirst() to std library #3925

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

garysassano
Copy link
Collaborator

@garysassano garysassano commented Aug 23, 2023

Closes #3833

  • MutArray.popAt()
  • MutArray.removeFirst()

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner August 23, 2023 04:11
@garysassano garysassano changed the title add MutArray.popAt() and MutArray.removeFirst() to std library add mutarray.poptt() and mutarray.removefirst() to std library Aug 23, 2023
@garysassano garysassano changed the title add mutarray.poptt() and mutarray.removefirst() to std library add mutarray.popat() and mutarray.removefirst() to std library Aug 23, 2023
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 23, 2023
@garysassano garysassano force-pushed the garysassano/array-remove branch 2 times, most recently from 6dea9f4 to 90249ef Compare August 23, 2023 05:12
@garysassano garysassano changed the title add mutarray.popat() and mutarray.removefirst() to std library feat(sdk): add mutarray.popat() and mutarray.removefirst() to std library Aug 23, 2023
Signed-off-by: monada-bot[bot] <[email protected]>
@garysassano garysassano changed the title feat(sdk): add mutarray.popat() and mutarray.removefirst() to std library feat(sdk): add MutArray.popAt() and MutArray.removeFirst() to std library Aug 23, 2023
libs/wingsdk/src/std/array.ts Show resolved Hide resolved
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 30, 2023
@monadabot
Copy link
Contributor

monadabot commented Aug 30, 2023

Console preview environment is available at https://wing-console-pr-3925.fly.dev 🚀

Updated (UTC): 2023-08-30 14:47

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 30, 2023
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/array-remove is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 30, 2023
@mergify mergify bot merged commit 95d0396 into main Aug 30, 2023
12 checks passed
@mergify mergify bot deleted the garysassano/array-remove branch August 30, 2023 16:20
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.27.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MutArray.remove(item), MutArray.removeAt(index)
5 participants