feat(sdk): adding datetime type
#3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuf239
changed the title
datetime typedatetime type
Chriscbr
reviewed
Jul 27, 2023
Co-authored-by: Hasan <[email protected]>
Co-authored-by: Hasan <[email protected]>
Co-authored-by: Hasan <[email protected]>
Co-authored-by: Hasan <[email protected]>
Co-authored-by: Hasan <[email protected]>
Co-authored-by: Hasan <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
approved these changes
Jul 31, 2023
tsuf239
removed
the
⚠️ pr/review-mutation
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
8 tasks
|
Congrats! 🚀 This was released in Wing 0.24.58. |
Closed
5 tasks
Merged
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ember accessibility (#3725) Following @Chriscbr's comment: #3570 (comment) I added those two rules to the SDK's linter and ran it once to apply them. The added regulations are: * capitalizing comment- makes sure comments and doc strings are capitalized * explicit member accessibility- makes sure that all methods and properties are marked with the right member accessibility- public, protected, or private I also added a sentence to the docs referring to the importance of docstrings, which should be capitalized. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [ ] Tests added (always) - [x] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2102
(besides adding the type mapping, opened a separate issue: #3569)
a wing test added, checked both preflight and inflight both in tf-aws and sim.
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.