Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confusing error message when returning value from void functions #3098

Merged
merged 7 commits into from
Jun 28, 2023
Merged

fix: confusing error message when returning value from void functions #3098

merged 7 commits into from
Jun 28, 2023

Conversation

eladcon
Copy link
Collaborator

@eladcon eladcon commented Jun 27, 2023

Checks whether the return statement is within a context of a void function and provides a clearer message.

Fixes #1550

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@eladcon eladcon requested a review from a team as a code owner June 27, 2023 13:15
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @eladcon 🙂

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 014dd96 into winglang:main Jun 28, 2023
11 checks passed
@eladcon eladcon deleted the return-message branch June 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when returning a value in a function typed as returning void
2 participants