Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.reflect.Type field kind should be enum #7184

Open
Chriscbr opened this issue Sep 30, 2024 · 0 comments
Open

std.reflect.Type field kind should be enum #7184

Chriscbr opened this issue Sep 30, 2024 · 0 comments
Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK

Comments

@Chriscbr
Copy link
Contributor

Chriscbr commented Sep 30, 2024

Use Case

To reduce bugs with writing code that is reflection heavy and dispatches based on what types have been reflected, it would be preferable to restrict the "kind" field to a fixed set of choices.

Example, instead of:

let t = @type(Array<str>);
assert(t.kind == "array");

it can be:

assert(t.kind == std.reflect.TypeId.ARRAY);
// or
assert(t.kind == .ARRAY);

Proposed Solution

No response

Implementation Notes

No response

Component

Compiler, SDK

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Discord.
@Chriscbr Chriscbr added ✨ enhancement New feature or request 🎨 sdk SDK needs-discussion Further discussion is needed prior to impl labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK
Projects
None yet
Development

No branches or pull requests

1 participant