Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.InflightBucketEvent should be renamed to python.InflightBucketEventHandler #6728

Closed
ekeren opened this issue Jun 17, 2024 · 4 comments
Labels
🐛 bug Something isn't working good first issue Good for newcomers 📚 libraries Wing Libraries refactor

Comments

@ekeren
Copy link
Collaborator

ekeren commented Jun 17, 2024

I tried this:

We need to have Handler suffix on all python Handlers

This happened:

NA

I expected this:

No response

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@ekeren ekeren added the 🐛 bug Something isn't working label Jun 17, 2024
@Chriscbr Chriscbr added the 📚 libraries Wing Libraries label Jun 21, 2024
@staycoolcall911
Copy link
Contributor

Should be easy to rename in the python winglib

@DoronV
Copy link
Contributor

DoronV commented Jun 26, 2024

Does this only apply to InflightBucketEvent, or also to the other handlers in the lib/file?

@revitalbarletz
Copy link
Contributor

Does this only apply to InflightBucketEvent, or also to the other handlers in the lib/file?

Other handlers as well! Would you like to take this one?

@staycoolcall911
Copy link
Contributor

@revitalbarletz it was actually done by @DoronV in winglang/winglibs#273 but the issue was left open. I'll close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers 📚 libraries Wing Libraries refactor
Projects
Status: Done
Development

No branches or pull requests

5 participants