Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard library: utility functions #3096

Closed
4 tasks done
staycoolcall911 opened this issue Jun 27, 2023 · 5 comments
Closed
4 tasks done

Standard library: utility functions #3096

staycoolcall911 opened this issue Jun 27, 2023 · 5 comments
Assignees
@jianzs
Labels
✨ enhancement New feature or request good first issue Good for newcomers 🎨 sdk SDK

Comments

@staycoolcall911
Copy link
Contributor

staycoolcall911 commented Jun 27, 2023 •
edited
Loading

Feature Spec

A number of simple utility functions are added to Wing's standard library as described in the RFC.
This includes the following modules:

  • math
  • fs
  • util

http module was already previously added.

  • http

Use Cases

Support simple programming needs such as performing math or file-system operations.

Implementation Notes

util module: env, tryEnv and sleep were done previously (see the source under https://github.com/winglang/wing/blob/main/libs/wingsdk/src/util/util.ts). Still need to add the rest of the methods defined in the RFC.

Component

SDK

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@staycoolcall911 staycoolcall911 added ✨ enhancement New feature or request 🎨 sdk SDK labels Jun 27, 2023
@revitalbarletz revitalbarletz added the good first issue Good for newcomers label Jun 27, 2023
@revitalbarletz
Copy link
Contributor

@marciocadev is working on the math module.

skorfmann added a commit to winglang/examples that referenced this issue Jul 18, 2023
@skorfmann
Add reference for winglang/wing#3096
79d8543
@staycoolcall911
Copy link
Contributor Author

The only thing left to close this one is adding a simple fs module as defined in the RFC here.

@staycoolcall911
Copy link
Contributor Author

@marciocadev - took you off this issue, because you already added the math and util modules, but if you want to implement the fs module as well please reassign this to yourself. Thanks!

@jianzs
Copy link
Contributor

jianzs commented Aug 24, 2023

Hey, there. I am working on the fs module.

@jianzs jianzs mentioned this issue Sep 10, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Oct 13, 2023
@jianzs
feat(sdk): add fs module (#4135)
94e3953 
Solves #3096 

Support fs module. All file paths are POSIX file paths, and will be normalized to the target platform when performing operations.

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [x] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@staycoolcall911
Copy link
Contributor Author

Closed by #4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jianzs jianzs

Labels
✨ enhancement New feature or request good first issue Good for newcomers 🎨 sdk SDK
Projects
Wing
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@revitalbarletz @jianzs @marciocadev @staycoolcall911