From c83eaf7f975fc1ff7e41c1e5514c31503b6253ea Mon Sep 17 00:00:00 2001 From: Tsuf Cohen <39455181+tsuf239@users.noreply.github.com> Date: Wed, 11 Oct 2023 17:30:19 +0300 Subject: [PATCH] chore: skip std spec tests (#4504) ## Description Currently, there are plenty of tests in a single file of any std test, and our current test scope (which duplicates resources by the number of tests) isn't handling it well, so we often get timeouts and exceptions. Since the std tests' code is identical both on aws and the sim (and tested in the sim via hangar) I think we can skip it until the [testing issue](https://github.com/winglang/wing/issues/3168) resolves. link to test run: https://github.com/winglang/wing/actions/runs/6480615481 ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*. --- .github/workflows/build.yml | 2 +- .github/workflows/tf-aws-test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 05e9f4a4a32..01308405f40 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -316,7 +316,7 @@ jobs: with: message: | Console preview environment is available at https://${{env.APP_NAME}}.fly.dev :rocket: - + ###### Last Updated (UTC) ${{steps.deploy-fly.outputs.deploytime }} comment_tag: Console preview environment GITHUB_TOKEN: ${{secrets.PROJEN_GITHUB_TOKEN}} diff --git a/.github/workflows/tf-aws-test.yml b/.github/workflows/tf-aws-test.yml index 3e64eb51344..5d1a1330362 100644 --- a/.github/workflows/tf-aws-test.yml +++ b/.github/workflows/tf-aws-test.yml @@ -51,8 +51,8 @@ jobs: - name: Get list of directories and save them to the output id: setdirs shell: bash - run: | - dirs=$(ls -d examples/tests/sdk_tests/*/ | sed 's/\/$//' | grep -v "external" | jq -R -s -c 'split("\n")[:-1]') + run: | # TODO: skipping std and external folders, when https://github.com/winglang/wing/issues/3168 is resolve- we'll skip only the external folder. + dirs=$(ls -d examples/tests/sdk_tests/*/ | sed 's/\/$//' | grep -v "external\|std" | jq -R -s -c 'split("\n")[:-1]') processed_dirs=$(echo "{ \"directory\": $dirs }" | jq -c '[ .directory[] | {directory: ., name: (split("/") | last)}]') wrapped_dirs=$(echo "{ \"test\": $processed_dirs }" | jq -c .) echo "dirs=$wrapped_dirs" >> $GITHUB_OUTPUT