WINDUPRULE-1041 jakarta cdi to quarkus rules #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to fix test failures
* cgi to quarkus rules for jakarta classes * remove failing groovy tests
m-brophy
changed the title
m-brophy
changed the title
m-brophy
added
auto-backport-to-releases/6.3.z
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* WINDUPRULE-1041 Work in progress * Update jakarta-cdi-to-quarkus.windup.test.xml attempt to fix test failures * Winduprule 1041 (#9) * cgi to quarkus rules for jakarta classes * remove failing groovy tests --------- Co-authored-by: Phil Cattanach <[email protected]> Co-authored-by: Mark Brophy <[email protected]> (cherry picked from commit 31dd0b8)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Jan 17, 2024
* WINDUPRULE-1041 Work in progress * Update jakarta-cdi-to-quarkus.windup.test.xml attempt to fix test failures * Winduprule 1041 (#9) * cgi to quarkus rules for jakarta classes * remove failing groovy tests --------- Co-authored-by: Phil Cattanach <[email protected]> Co-authored-by: Mark Brophy <[email protected]> (cherry picked from commit 31dd0b8) Co-authored-by: Phil Cattanach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mark,
I have created this PR to try to create an equivalent ruleset to quarkus/java-ee/cdi-to-quarkus.windup.xml but to work for the jakarta rather than javax classes.
The tests fail for the last 2 rules in the ruleset so I assumed I had to add the jakarta classes in order for them to work.
I have done that copying the example from https://github.com/windup/windup-rulesets/pull/630/files that Juanma implemented.
However those final two rules still aren't working and I don't know why.
Would you mind investigating please?