Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #32

Open
nbur4556 opened this issue Dec 9, 2020 · 2 comments
Open

Dark Mode #32

nbur4556 opened this issue Dec 9, 2020 · 2 comments

Comments

@nbur4556
Copy link

nbur4556 commented Dec 9, 2020

Github released a dark mode today! I found your repo and wanted to start implementing a dark mode for the extension.

Here are some examples that have been put together so far:
example-1

example-2

example-3

I'll continue working on this, but let me know if something like this would be useful. And if so, let me know if you have any preferences on how to go about contributing. Specifically, if you have preferences on how you would like dark mode organized within the codebase.

Cheers!

@nicknamedelta
Copy link

Hello @nbur4556, I also think this functionality can be useful, so I thought of a solution. I will be happy to help in this too.

Here's an example of my implementation working:

github-contribution-color-graph

@nbur4556
Copy link
Author

This looks great! What I was doing was just creating separate themes for dark mode, but it would not update automatically like that. The separate themes still might be nice to have, especially for the material themes. I personally think it looks wrong the way they are with the dark background, and the colors should be inverted (dark to light).

I've put the material design themes put together if you'd like I can submit a pull request. It needs more work, I planned to make them look a little better and get them organized, however, I'm in a Bootcamp, and recently got a lot more work than I was expecting. Just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants