-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a blog post: Using the maven-wildfly-plugin to provision the Wild… #677
Conversation
@bstansberry @jamezp I'm not sure whether this is proper to be published here, could you please help to review it when you have time? Thanks! |
Just a comment, maybe it is worth mentioning that there are WildFly Guides to describe how to integrate the server with a database, for example this one is specific to PostgreSQL https://www.wildfly.org/guides/database-integrating-with-postgresql You could point the reader out to those guides if he wants to deepen on this subject, for example in that Guide we explain how to use WildFly Glow to discover the layers |
@yersan Okay! btw the Glow usage looks great :D |
Yes, it is, kudos going to @jfdenise ! |
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
@jamezp Thanks for the detail review James! I'll modify the text accrodingly. |
d4d10a3
to
44a487f
Compare
@jamezp I have finished updating the text. Could you please help to review the changes when you have time? Thanks! |
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
44a487f
to
5bb6718
Compare
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
@jamezp Thanks for the detailed review! I'll update the text accordingly :D |
Relative PR to split the |
I'll update the text and squash the commits today. |
@jamezp, I have finished updating the text based on your comments. In addition, I have added the parts that explain the two different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things, then please squash. Other than that, this looks good to me. Thank you @liweinan
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
_posts/2024-10-28-using-maven-wildfly-plugin-with-postgresql-ds.adoc
Outdated
Show resolved
Hide resolved
…Fly to use the PostgreSQL datasource.
d6f0912
to
6ebe6f8
Compare
@jamezp Thanks for reviewing! I have updated the text and squashed the commits(and also updated the post date). |
Thank you @liweinan |
…Fly to use the PostgreSQL datasource.