Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog post: Using the maven-wildfly-plugin to provision the Wild… #677

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

liweinan
Copy link
Contributor

…Fly to use the PostgreSQL datasource.

@liweinan
Copy link
Contributor Author

@bstansberry @jamezp I'm not sure whether this is proper to be published here, could you please help to review it when you have time? Thanks!

@yersan
Copy link
Contributor

yersan commented Oct 28, 2024

Just a comment, maybe it is worth mentioning that there are WildFly Guides to describe how to integrate the server with a database, for example this one is specific to PostgreSQL https://www.wildfly.org/guides/database-integrating-with-postgresql

You could point the reader out to those guides if he wants to deepen on this subject, for example in that Guide we explain how to use WildFly Glow to discover the layers

@liweinan
Copy link
Contributor Author

@yersan Okay! btw the Glow usage looks great :D

@yersan
Copy link
Contributor

yersan commented Oct 29, 2024

Yes, it is, kudos going to @jfdenise !

@liweinan
Copy link
Contributor Author

@jamezp Thanks for the detail review James! I'll modify the text accrodingly.

@liweinan liweinan force-pushed the 2024-10-28-postgresql branch 2 times, most recently from d4d10a3 to 44a487f Compare November 3, 2024 16:00
@liweinan
Copy link
Contributor Author

liweinan commented Nov 3, 2024

@jamezp I have finished updating the text. Could you please help to review the changes when you have time? Thanks!

@liweinan
Copy link
Contributor Author

liweinan commented Nov 6, 2024

@jamezp Thanks for the detailed review! I'll update the text accordingly :D

@liweinan
Copy link
Contributor Author

Relative PR to split the postgres-driver and the postgres-datasource profiles in the example: jberet/jberet-examples#16

@liweinan
Copy link
Contributor Author

I'll update the text and squash the commits today.

@liweinan
Copy link
Contributor Author

@jamezp, I have finished updating the text based on your comments. In addition, I have added the parts that explain the two different postgres profiles according to our changes to the example. Could you please help to review it again? If everything is fine I'll squash the commits of this PR and update the post date :D Thanks!

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things, then please squash. Other than that, this looks good to me. Thank you @liweinan

@liweinan
Copy link
Contributor Author

@jamezp Thanks for reviewing! I have updated the text and squashed the commits(and also updated the post date).

@jamezp jamezp merged commit 3f3c0d9 into wildfly:main Nov 14, 2024
@jamezp
Copy link
Member

jamezp commented Nov 14, 2024

Thank you @liweinan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants