Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18769] Add 'Browse the source' links to all the QS READMEs that… #830

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

emmartins
Copy link
Contributor

… target the GitHub quickstart repo
Issue: https://issues.redhat.com/browse/WFLY-18769
3rd and final part of this new functionality, moves all QSes to parent v6 and adds the "view the source" link on every README.adoc

@emmartins
Copy link
Contributor Author

emmartins commented Dec 20, 2023

@bstansberry started with your commit, added microprofile-lra (new QS merged since you did the commit) and changed the view-the-source.adoc to use the attribute with latest github tag, instead of the pom version.

Copy link

openshift-ci bot commented Dec 20, 2023

@emmartins: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/wildfly-quickstart-e2e 8737ae1 link true /test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -1,3 +1,3 @@
ifndef::ProductRelease,EAPXPRelease[]
link:https://github.com/wildfly/quickstart/tree/{artifactVersion}/{artifactId}[Browse the source]
link:https://github.com/wildfly/quickstart/tree/{WildFlyQuickStartRepoTag}/{artifactId}[Browse the source]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if I'd known about this there'd not have been a need for the parent upgrade. :)

Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @emmartins

@emmartins emmartins merged commit 677c920 into wildfly:main Dec 20, 2023
412 of 416 checks passed
@emmartins emmartins deleted the WFLY-18769-pt3 branch December 20, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants