Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Clear out edit data upon logout, populate data upon login and settings toggle #5074

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T378135

Notes

This PR clears out the user's YiR editing data upon logout, so that if they log in with a different username they will not see the old edit count slide.

I also did some cleanup with data population, so that we don't have to background / foreground as often. I am now also populating data upon login and whenever the YiR settings toggle is turned on.

Test Steps

  1. Log into an account with editing data. Confirm you see account reflected in Year in Review.
  2. Log out.
  3. Log into another account with a different edit count. Confirm you see new count in Year in Review.
  4. Go to app Settings, turn off year in review. Confirm entry point disappears. Go back to settings and turn year in review back on. Confirm entry point comes back without needing to background/foreground.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team November 14, 2024 22:01
@l-olson1214 l-olson1214 merged commit e1e6356 into main Nov 15, 2024
4 checks passed
@l-olson1214 l-olson1214 deleted the yir-data-population-cleanup branch November 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants