Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine with cacheable beacon proxy to make it upgradable #9

Open
BlinkyStitt opened this issue Mar 15, 2022 · 2 comments
Open

Combine with cacheable beacon proxy to make it upgradable #9

BlinkyStitt opened this issue Mar 15, 2022 · 2 comments

Comments

@BlinkyStitt
Copy link

BlinkyStitt commented Mar 15, 2022

Having upgradability and some immutables could be helpful for my current project. https://github.com/frangio/cacheable-beacon-proxy/blob/master/contracts/CacheableBeaconProxy.sol

@BlinkyStitt
Copy link
Author

I've thought about it some more and I'm not sure how best to do this. Deploying the "cache" would be expensive since it clones the implementation and not the thin proxy. And I think multiple layers of delegatecall is probably not worth the gas cost.

@BlinkyStitt
Copy link
Author

I think if we:

  1. change https://github.com/frangio/cacheable-beacon-proxy/blob/master/contracts/CacheableBeaconProxy.sol#L92 to deploy a simple delegatecall proxy
  2. change https://github.com/frangio/cacheable-beacon-proxy/blob/master/contracts/CacheableBeaconProxy.sol#L82 to include the extra data in the calldata

then it might work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant