Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Implement redirecting in solara routing #576

Merged

Conversation

iisakkirotko
Copy link
Collaborator

docs: Implement redirecting in solara routing

We recently implemented this in the server to redirect moved pages for the docs. However, that did not prevent such errors in internal routing, which is implemented by this PR.

docs: redirect fullscreen apps automatically

Copy link

render bot commented Mar 28, 2024

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko force-pushed the 03-28-docs_implement_redirecting_in_solara_routing branch from d168493 to e2f841d Compare March 28, 2024 16:04
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! maybe rebase the last commit?

We recently implemented this in the server to redirect moved pages for the docs. However, that did not prevent such errors in internal routing, which is implemented by this PR.
@iisakkirotko iisakkirotko force-pushed the 03-28-docs_implement_redirecting_in_solara_routing branch from e2f841d to 8803022 Compare April 2, 2024 10:45
@iisakkirotko iisakkirotko merged commit 40e8fa8 into master Apr 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants