Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ThemeToggle becoming invisible against "primary" background #537

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented Mar 4, 2024

Fixes #528

@iisakkirotko iisakkirotko force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from c202ebd to 89236b8 Compare March 4, 2024 15:05
@iisakkirotko iisakkirotko force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from eba57db to afcc9ca Compare March 4, 2024 15:43
@iisakkirotko iisakkirotko force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from 89236b8 to b3110bf Compare March 8, 2024 09:47
@iisakkirotko iisakkirotko force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from afcc9ca to d3338ba Compare March 8, 2024 09:47
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from b3110bf to e28ee64 Compare March 8, 2024 12:39
@iisakkirotko iisakkirotko force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from e28ee64 to 7fe9e73 Compare March 8, 2024 13:26
@iisakkirotko iisakkirotko force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from d3338ba to 33d4d0e Compare March 8, 2024 13:26
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from 7fe9e73 to f97997e Compare March 8, 2024 13:57
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from 33d4d0e to ef9630d Compare March 8, 2024 13:57
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from f97997e to f314558 Compare March 8, 2024 14:02
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from ef9630d to a79d5ff Compare March 8, 2024 14:02
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_solara_theming_not_respecting_theme.js_file branch from f314558 to 1ebb204 Compare March 10, 2024 21:24
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from a79d5ff to 48bf8aa Compare March 10, 2024 21:24
Copy link
Contributor

maartenbreddels commented Mar 11, 2024

Merge activity

@maartenbreddels maartenbreddels changed the base branch from 03-04-fix_solara_theming_not_respecting_theme.js_file to master March 11, 2024 09:06
@maartenbreddels maartenbreddels force-pushed the 03-04-fix_ThemeToggle_becoming_invisible_against_primary_background branch from 48bf8aa to 112e10e Compare March 11, 2024 09:08
@maartenbreddels maartenbreddels merged commit 9bae8f1 into master Mar 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme toggle button dark mode becomes invisible with colored app bar
2 participants