Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split assets settings in server and non-server parts #487

Merged
merged 1 commit into from
Jan 30, 2024
Merged

refactor: split assets settings in server and non-server parts #487

merged 1 commit into from
Jan 30, 2024

Conversation

maartenbreddels
Copy link
Contributor

Based on:

We decided that using the proxy and the cdn if the proxy is not used
is not only something to be used in solara server. In vscode
or colab, we cannot use the proxy, and need to use the cdn directly.

@maartenbreddels Graphite App
Copy link
Contributor Author

maartenbreddels commented Jan 29, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@maartenbreddels maartenbreddels mentioned this pull request Jan 29, 2024
Merged
@maartenbreddels
refactor: split assets settings in server and non-server parts
0ad109c 
Based on:
 * #479
 * #480
 * #486

We decided that using the proxy and the cdn if the proxy is not used
is not only something to be used in solara server. In vscode
or colab, we cannot use the proxy, and need to use the cdn directly.
@maartenbreddels maartenbreddels force-pushed the 01-29-refactor_split_assets_settings_in_server_and_non-server_parts branch from da06303 to 0ad109c Compare January 30, 2024 08:56
@maartenbreddels Graphite App
Copy link
Contributor Author

maartenbreddels commented Jan 30, 2024 •
edited
Loading

Merge activity

@maartenbreddels maartenbreddels merged commit 2e0b110 into master Jan 30, 2024
46 of 47 checks passed
@maartenbreddels maartenbreddels mentioned this pull request Jan 30, 2024
Merged
iisakkirotko added a commit that referenced this pull request Jan 30, 2024
@iisakkirotko
refactor: use new settings structure (see #487)
f882941
@maartenbreddels maartenbreddels mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maartenbreddels