fix: baseUrl should not be suffixed with /jupyter #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2023
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
maartenbreddels
force-pushed
the
10-04-fix_starlette_websocket_close_called_itself_recursively
branch
from
7e10715
to
a14f070
Compare
maartenbreddels
force-pushed
the
10-04-fix_baseUrl_should_not_be_suffixed_with_/jupyter
branch
from
59a0d4e
to
1c1478f
Compare
The fact that this did not affect our code is an indication that we are not using it internally. Using ipypopout, this bug was found, because it does use the baseUrl.
maartenbreddels
changed the base branch from
10-04-fix_starlette_websocket_close_called_itself_recursively
to
master
maartenbreddels
force-pushed
the
10-04-fix_baseUrl_should_not_be_suffixed_with_/jupyter
branch
from
1c1478f
to
9691007
Compare
maartenbreddels
added a commit
that referenced
this pull request
Oct 5, 2023
The fact that this did not affect our code is an indication that we are not using it internally. Using ipypopout, this bug was found, because it does use the baseUrl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that this did not affect our code is an indication that we
are not using it internally. Using ipypopout, this bug was found,
because it does use the baseUrl.