Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: do not run all runners in ipywidgets_runner fixture #310

Merged
merged 1 commit into from
Oct 6, 2023
Merged

refactor: do not run all runners in ipywidgets_runner fixture #310

merged 1 commit into from
Oct 6, 2023

Commits on Sep 29, 2023

  1. refactor: do not run all runners in ipywidgets_runner fixture 

    Each time the ipywidgets_runner fixture was used, all fixtures
are used. This means the ipywidgets_runner_solara runner was
also used, causing the solara_test fixture to always run
and also close the app each time, which close all the contexts.

This is bad for performance of the tests, but it is possibly also
the cause for some flakeyness in our tests.
    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    32b10af View commit details
    Browse the repository at this point in the history