Feat: Menu, ClickMenu, and ContextMenu components for solara.lab #295
+292
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
changed the title
iisakkirotko
force-pushed
the
feat-menu
branch
3 times, most recently
from
0e2fa9b
to
2ce4942
Compare
iisakkirotko
force-pushed
the
feat-menu
branch
2 times, most recently
from
8bc77c5
to
026e0ed
Compare
feat: API docs for ClickMenu and ContextMenu feat: Added Menu component feat: Documentation for Menu component feat: Documentation for Menu component
Pictures are reference files for visual tests. Tests only run in solara, since other environments seem to have issues with parametrization.
Clicking on elements instead of pixel coordinates. ALso switched to `to_be_in_viewport` from `to_be_visible`
iisakkirotko
force-pushed
the
feat-menu
branch
from
026e0ed
to
9445140
Compare
maartenbreddels
requested changes
Oct 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Menu, ClickMenu, and ContextMenu components, as well as documentation for them.