fix: subpackage changes not autoreloaded #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solara/server/app.py
Outdated
Comment on lines
85
to
86
| package_root_path = Path(mod.__file__).parent | ||
| reload.reloader.root_path = package_root_path |
There was a problem hiding this comment.
I think this needs to be conditional (looking at the mypy error) when mod.file is None, we just skip this I think.
There was a problem hiding this comment.
Made the change. Shouldn't worry too much about the ~30 errors from Python 3.9?
There was a problem hiding this comment.
Yes, but it is a seperate issue, we don't need to fix it in this PR.
|
Also fixes #242 |
|
Thanks 👍 |
iisakkirotko
added a commit
to iisakkirotko/solara
that referenced
this pull request
Sep 29, 2023
…ti#293) * fix: subpackage changes not autoreloaded * fix: MyPy error when mod.__file__ is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #281.