Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use_thread shortly contains old value when finished #267

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: use_thread shortly contains old value when finished #267

wants to merge 2 commits into from

Conversation

mariobuikhuizen
Copy link
Contributor

No description provided.

@mariobuikhuizen mariobuikhuizen force-pushed the fix_use_thread_shortly_contains_old_value_when_finished branch from 006d7bc to 4653f13 Compare September 4, 2023 12:06
@maartenbreddels
Copy link
Contributor

I pushed a possible fix, but this needs a longer discussion and more thinking. One edge case that I can think of is that I'm not sure what happens if the dependencies are the same again as before, possibly not triggering a use_effect.

@maartenbreddels maartenbreddels marked this pull request as draft September 6, 2023 11:53
@iisakkirotko iisakkirotko force-pushed the master branch 2 times, most recently from c2951b9 to 8816e36 Compare April 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariobuikhuizen @maartenbreddels