Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run pre commit in ci for code quality #225

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ci: run pre commit in ci for code quality #225

wants to merge 8 commits into from

Conversation

maartenbreddels
Copy link
Contributor

No description provided.

@maartenbreddels
Copy link
Contributor Author

Instead of manually keeping pre-commit versions in sync with CI, lets also use pre-commit in CI

@maartenbreddels maartenbreddels force-pushed the ci_use_pre_commit branch 2 times, most recently from 82b19e2 to 8aa58c7 Compare July 31, 2023 13:04
@maartenbreddels
Copy link
Contributor Author

Giving up for now, I have no idea why isort under Python 3.9 decides to reorder imports.

@maartenbreddels maartenbreddels added the help wanted Extra attention is needed label Jul 31, 2023
@maartenbreddels
Copy link
Contributor Author

After d15ec01 it seems that we cannot install isort on Python 3.7 anymore. Might be a clue that the isort on 3.9 in pre commit does not respect the version number in the pre commit file.

@mariobuikhuizen mariobuikhuizen mentioned this pull request Sep 7, 2023
Closed
@maartenbreddels maartenbreddels mentioned this pull request Oct 30, 2023
Open
@iisakkirotko iisakkirotko force-pushed the master branch 2 times, most recently from c2951b9 to 8816e36 Compare April 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maartenbreddels