Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cap pydantic < 2.0 #190

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

lp9052
Copy link
Contributor

@lp9052 lp9052 commented Jun 30, 2023

due to pydantic breaking change.

see #187

due to pydantic breaking change
@maartenbreddels
Copy link
Contributor

I agree, we first merge this, get CI green and see if we can get it working with 2 very soon, or do a release with a cap (I hate caps, so I prefer not to release with it :P)

@maartenbreddels maartenbreddels merged commit 5c26b61 into widgetti:master Jul 1, 2023
21 checks passed
@maartenbreddels
Copy link
Contributor

Thanks!

@lp9052
Copy link
Contributor Author

lp9052 commented Jul 1, 2023

Ouch. Thanks for deduplicate it. Can't believe I made this mistake. Should we alphabetically sort the dependencies list. To avoid future issue like this.

@maartenbreddels
Copy link
Contributor

Np 🙂
I prefer as little changes as possible to make it easier to track changes, but if it bothers you a lot, a single sort pr is ok.
I should have sorted it from the beginning…

@lp9052 lp9052 deleted the fix_cap_pydantic_version branch July 11, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants